Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: V3 split towards a V3 Only World #1189

Open
wants to merge 16 commits into
base: release/3.0.0
Choose a base branch
from

Conversation

alexrisch
Copy link
Collaborator

No description provided.

Started some work on V3 Message Component
Cleaned up several Components
Cleaned up list merging
Better query handling for messages
Message Status
Chat message work
Message Status
Chat message work
* feat: Update to use inbox id endpoint

Added new query to use inbox endpoint
Updated usage for group avatar/members
Updated socials type to match what is being returned from the server

* feat: Remove Inbox Id store

Remove inbox id store

* Updates

Added tests
Split util files
Added helper util functions
Added helper hooks

* Updated to map and filter
Added helpers
Updated naming to match v3 rather than just groups
Updated Pinned Conversations and Conversation List
Fix for missing function
Moved util functions to separate files
Removed helpers/index files
Prepared media attachments for split from V2 handling

:
Added V3 Message and V3Message to Display
Added conversation context to help reduce overall changes
@alexrisch alexrisch requested a review from a team as a code owner November 13, 2024 18:58
Copy link
Contributor

github-actions bot commented Nov 13, 2024

Performance Comparison Report

  • Current: 8fd3b1f - 2024-11-13 21:56:42Z
  • Baseline: release/3.0.0 (3f53b99) - 2024-11-13 21:55:42Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Avatar Image 10 runs render 1.3 ms → 1.2 ms (-0.1 ms, -7.7%) 1 → 1
Avatar Image 50 runs render 1.0 ms → 1.1 ms (+0.0 ms, +1.9%) 1 → 1
Empty Avatar 10 runs render 1.2 ms → 0.9 ms (-0.3 ms, -25.0%) 🟢 1 → 1
Empty Avatar 50 runs render 0.7 ms → 0.8 ms (+0.1 ms, +8.6%) 1 → 1
Show details
Name Type Duration Count
Avatar Image 10 runs render Baseline
Mean: 1.3 ms
Stdev: 0.5 ms (37.2%)
Runs: 2 1 1 2 1 1 1 2 1 1
Warmup runs: 3

Current
Mean: 1.2 ms
Stdev: 0.4 ms (35.1%)
Runs: 1 1 1 2 1 1 1 2 1 1
Warmup runs: 2
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Avatar Image 50 runs render Baseline
Mean: 1.0 ms
Stdev: 0.4 ms (38.7%)
Runs: 1 1 1 0 1 1 2 2 1 1 2 1 1 1 1 1 1 1 0 1 1 0 1 1 1 1 1 2 1 1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Warmup runs: 2

Current
Mean: 1.1 ms
Stdev: 0.3 ms (29.6%)
Runs: 1 2 1 1 1 1 2 1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 0 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Warmup runs: 1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 10 runs render Baseline
Mean: 1.2 ms
Stdev: 0.4 ms (35.1%)
Runs: 2 1 1 1 1 2 1 1 1 1
Warmup runs: 81

Current
Mean: 0.9 ms
Stdev: 0.3 ms (35.1%)
Runs: 1 1 1 1 1 1 1 1 0 1
Warmup runs: 8
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 50 runs render Baseline
Mean: 0.7 ms
Stdev: 0.5 ms (72.2%)
Runs: 1 1 0 1 1 1 1 1 0 1 1 2 1 1 0 1 1 1 1 0 1 0 1 1 0 1 1 0 0 1 0 1 0 1 0 0 1 1 0 1 1 0 1 1 1 0 1 1 1 0
Warmup runs: 1

Current
Mean: 0.8 ms
Stdev: 0.5 ms (62.7%)
Runs: 1 1 1 1 1 0 0 1 1 2 1 1 1 1 0 0 0 1 1 1 1 1 1 1 0 1 1 1 1 1 1 1 0 0 0 1 1 1 1 0 1 0 1 1 0 0 1 1 1 1
Warmup runs: 0
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Render Count Changes

There are no entries

Render Issues

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 578d8dc

@alexrisch alexrisch changed the title Feature/v3 split Feature: V3 split towards a V3 Only World Nov 13, 2024
Added blocked view support
Cleaned up tsc
Added helper query config
Added API setting pinned conversations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant